1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/js_bbs.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Feb 14 23:17:15 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/829b425a66a9a9a19bca692e
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix memory leaks in error paths of js_show_msg_header()

    Identified by Coverity.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Apr 4 13:38:22 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f576cbc69be99cfff5adace5
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix unsigned int compare to negative - caught by Coverity-scan

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed May 26 23:09:11 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/485440f1ea548f7362b26dbc
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    New bbs.view_file(filename) method.

    To list/view file/archive contents.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu May 27 23:33:42 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/536b7e227007cfb00af1865c
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Add bbs.export_filelist() method

    This is the last thing needed to complete the new temp/archive menu module implemented in JavaScript for v3.19.

    File list generation can easily be done in JS (see filelist.js for example), but since we have this function already in C++ (i.e. for including filelists in QWK packets) - might as well make it available for use in JS.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Jan 1 23:27:55 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/d8dcfa98fdb2d26137dcfaa5
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Resolve GCC warning

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sat Feb 25 21:54:11 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/4bf1af95762799dd9ebcc75c
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Create bbs.batch_clear() method

    Pass argument of 'true' to clear upload queue, otherwise download queue
    is cleared.

    This fixes issue #488

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Sun Feb 26 12:38:20 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/eb8ecbae6e4391883338181d
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix typo in JSDOC help for batch_clear() method.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sun Mar 5 19:12:15 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/7a5c6e363d8874a5a4943800
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Add JS bbs methods: save_msg_scan() and reload_msg_scan()

    These methods aren't normally needed (msg scan config/ptrs are
    automatically loaded upon logon and saved upon logoff), but for users
    (e.g. sysops) that can be logged-in concurrently or experimenting with
    scans, these methods can be useful and I plan to expose in a loadable
    module next.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sat Mar 11 14:09:39 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c9e2c1fbbc5c573e4ad6b08c
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    bbs.logoff() now returns a boolean: false if log-off was denied

    Previously, there was no good way for the caller to determine if the\
    user opted (when prompted) to actually log-off or not.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Mar 15 23:54:43 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/fbf99ab6addaae3794c52c91
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Add 'first_node' and 'last_node' properties to JS bbs object

    This allows scripts (e.g. login.js) to have custom behavior (e.g. shortening the maximum inactivity timeout) based on how close the current node is to the configured last node number. There may be other uses too, but for the vast majority of Synchronet systems, first_node will always be 1 and last_node the same as system.nodes/lastnode. Ugh, inconsistent naming. :-(

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Aug 8 13:23:25 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/0fbdf31cedaa84d4b674ecce
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Make argument to bbs.batch_clear() optional (clear downlaod queue by default)

    ... as appears to have been the intent

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Aug 10 19:44:50 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5a6714e3576a32a11106bae4
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix CIDs 508283 508284 508285 508286 508287

    HANDLE_PENDING() macro returns from the calling function (without freeing allocated resources), so don't use that here.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Oct 15 15:29:57 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/47eb42e6f96ba73d9146dc22
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Add missing file to commit 095368c0d7

    Not sure how I missed this one, but this file was needed to complete the
    'bbs' object changes mentioned in that commit message.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Oct 15 23:35:03 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/1df94b61610b47746fc56995
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix GCC warning (unused variable) introduced in last commit

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Oct 25 21:07:02 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9f27c430d8e5b7a89f181be7
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Add bbs.download_cps, batch_sort(), and batch_remove()

    Helpful for a JS batch file transfer menu

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Oct 27 22:00:26 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3c86324d6fb20148b55bad17
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    New method: bbs.xtrn_prot_menu()

    So we don't have to reimplement this logic in user_settings.js (or
    equivalent) any longer.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Oct 27 22:37:05 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/7f04c593a06de309e94c278c
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    bbs.xfer_prot_menu() now returns the list of protocol keys (mnemonics)

    ... that the user has access to

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Oct 28 17:54:56 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f50c866fd152678bde4c1083
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix CID 511447 with extra parens

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Nov 9 20:30:54 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/c9ec49e0f40b8af1e975bf09
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix logic in bbs.xfer_prot_menu()

    This was just a typo which didn't allow the single-file upload xfer prot menu to be shown.

    Actual fix for CID 11447 (previous attempt, commit f50c866fd was
    insufficient). Thank you Coverity!

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Nov 30 01:45:10 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/52460c3abc163308c7be1c62
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Range check argc before deref of argv[1]

    Apparently JSVAL_IS_STRING() can return true even when argv[1] is out of range (I guess I assumed it'd alwasy be NULL or VOID/undefined) and this can lead to crash when calling JS_ValueToString() on it.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net