Forum: The Lake House

src/syncterm/bbslist.c

From Deucе@VERT to Git commit to main/sbbs/master on Mon Mar 15 02:42:16 2021

https://gitlab.synchro.net/main/sbbs/-/commit/67469416d7681e6b377855a2
Modified Files:
src/syncterm/bbslist.c
Log Message:
Change default connection type from RLogin to SSH because it's 2021 dammit.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Mon Mar 15 03:43:01 2021

https://gitlab.synchro.net/main/sbbs/-/commit/fe33deb7d7abdf8253c2a09e
Modified Files:
src/syncterm/bbslist.c
Log Message:
Make log level selection a menu like every other non-binary option.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Mon Mar 15 12:02:27 2021

https://gitlab.synchro.net/main/sbbs/-/commit/6325bf4596f749354b0e0c2c
Modified Files:
src/syncterm/bbslist.c
Log Message:
Move log options into a separate menu and fix overflows

There are too many options now to fit in an 80x25 screen, so group
all the log options into a separate sub-menu.

While we're here, notice that we're writing paths up to MAX_PATH
into an 80-character buffer and fix that.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Thu Mar 18 10:19:49 2021

https://gitlab.synchro.net/main/sbbs/-/commit/4fd1f9cf53d86689b44a108e
Modified Files:
src/syncterm/bbslist.c
Log Message:
Fix menu draw when returning to dialing list from comment

Also note the spectacularily poorly named WIN_REDRAW and WIN_NODRAW
flags. WIN_REDRAW indicates that this *is* a redraw of the menu,
which indicates that you don't need to redraw the menu (because it's
already correct on screen). Weird, but not insane... WIN_NODRAW on
the other hand indicates this is *not* a redraw, and that the window
is incorrect on screen and you therefore *must* redraw the menu.

That is to say:
WIN_REDRAW prevents the window from being redrawn
WIN_NODRAW forces the window to be redrawn

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Mon Mar 29 16:55:44 2021

https://gitlab.synchro.net/main/sbbs/-/commit/9a4d3cd683daaab55ebf799d
Modified Files:
src/syncterm/bbslist.c
Log Message:
Fix issue with redrawing BBS list from settings menu

Sometimes the comment wasn't redrawn.
Also, remove configurable mouse actions stuff, not implemented in
13 years, I suspect I'll never do it.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Fri May 14 16:40:25 2021

https://gitlab.synchro.net/main/sbbs/-/commit/c389e6a5233e3c0e7fedda27
Modified Files:
src/syncterm/bbslist.c
Log Message:
Don't pass -1 as cur or bar.

Sheesh.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Mon May 17 18:42:29 2021

https://gitlab.synchro.net/main/sbbs/-/commit/f688ecceef4dd492558a6eeb
Modified Files:
src/syncterm/bbslist.c
Log Message:
Passing a NULL bar prevents *cur from being off the first screen.

Instead, just set bar to the end and let ulist() sort it out. It
sucks, but it sucks less.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Mon May 17 18:56:22 2021

https://gitlab.synchro.net/main/sbbs/-/commit/2167cb772586afbc83b010eb
Modified Files:
src/syncterm/bbslist.c
Log Message:
Fix off-by-one error in program settings.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Wed May 19 18:27:55 2021

https://gitlab.synchro.net/main/sbbs/-/commit/b8aa20b38db8b8d6823fe84b
Modified Files:
src/syncterm/bbslist.c
Log Message:
Recalculate list height before showing after mode change

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Fri May 21 18:35:04 2021

https://gitlab.synchro.net/main/sbbs/-/commit/baa471f6b1fb527849667b6a
Modified Files:
src/syncterm/bbslist.c
Log Message:
Fix custom mode font size picker

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Sat May 22 02:38:59 2021

https://gitlab.synchro.net/main/sbbs/-/commit/9231ac9baf5f509364c3c548
Modified Files:
src/syncterm/bbslist.c
Log Message:
Set mode by macro, not number

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed May 11 00:37:31 2022

https://gitlab.synchro.net/main/sbbs/-/commit/34cc10c1309dfb95b710ac42
Modified Files:
src/syncterm/bbslist.c
Log Message:
Explain that TAB is used to edit the entry comment in online help

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Fri Dec 23 18:23:49 2022

https://gitlab.synchro.net/main/sbbs/-/commit/216c8c737ecc6f59f6503fb9
Modified Files:
src/syncterm/bbslist.c
Log Message:
Add a "File Locations" menu item in the settings menu.

This doesn't actually contain things you can modify, but rather
answers the most FAQ "Where are the files stored?"

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Fri Dec 23 18:25:35 2022

https://gitlab.synchro.net/main/sbbs/-/commit/75b19e1ecc01157778805caa
Modified Files:
src/syncterm/bbslist.c
Log Message:
We don't need these braces.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Mar 29 12:40:18 2023

https://gitlab.synchro.net/main/sbbs/-/commit/4e78d51696a7414781a3d9f7
Modified Files:
src/syncterm/bbslist.c
Log Message:
Help text updates

Direct users to Program Settings->Startup Screen Mode for initial/default screen mode.

Wording update for Startup Screen Mode help.

Indent the File Locations less as these paths are usually much longer on Windows and is ugly when wrapped here.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sun Apr 16 13:05:51 2023

https://gitlab.synchro.net/main/sbbs/-/commit/1c6aa05e3413aeb9bbfeca2c
Modified Files:
src/syncterm/bbslist.c
Log Message:
If ":<port>" suffix is included in an added TCP address, parse/use it

When adding a BBS entry with a TCP connection, if a ":port" suffix is included (e.g. "vert.synchro.net:23"), parse and use that port number for the new entry automatically and remove the suffix from the adddress itself.
This is just a time saver when adding new BBS entries.

Care was taken to not treat the following addresses in this manner:
":<port>" - would have resulted in a blank address
"a::<port>" - possible IPv6 address
"a:<port>b" - possible IPv6 address or ... ?
"a:<invalid-port>"

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Mon May 1 13:59:10 2023

https://gitlab.synchro.net/main/sbbs/-/commit/969c3bb0ad1181654d62cc11
Modified Files:
src/syncterm/bbslist.c
Log Message:
Call kbwait() before wany uifc.list() we care about the return value of

Fixes high CPU utilization at menus.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Mon May 1 20:22:52 2023

https://gitlab.synchro.net/main/sbbs/-/commit/baa1408944428d7301e5375d
Modified Files:
src/syncterm/bbslist.c
Log Message:
Fix to high CPU utilization fix.

We don't just want the kbwait() problem back, only wait after WIN_DYN
if there was no input.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Thu Jun 8 21:37:47 2023

https://gitlab.synchro.net/main/sbbs/-/commit/c32f057a323fe2778ff84911
Modified Files:
src/syncterm/bbslist.c
Log Message:
Add missing break.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Mon Jul 3 20:26:18 2023

https://gitlab.synchro.net/main/sbbs/-/commit/f335e4e5b5a7f6b3e6de7d7a
Modified Files:
src/syncterm/bbslist.c
Log Message:
Fix missing NULL terminator for rip_versions string list

Caught be GCC ASan.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Mon Sep 30 17:48:22 2024

https://gitlab.synchro.net/main/sbbs/-/commit/0e009861dc6cf4bb4c29c9b3
Modified Files:
src/syncterm/bbslist.c
Log Message:
Fix the macro used to detect X11.

NO_X is defined in the ciolib GNUmakefile. DISABLE_X11 is defined
on Common.gmake.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Fri Oct 18 08:10:20 2024

https://gitlab.synchro.net/main/sbbs/-/commit/64ff68205c9e5227fbdec93a
Modified Files:
src/syncterm/bbslist.c
Log Message:
Don't copy the name to the address.

The DNS lookup can cause delays on some systems.
Fixes bug 154

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Wed Nov 20 14:34:07 2024

https://gitlab.synchro.net/main/sbbs/-/commit/631f98785ea5c866475982d8
Modified Files:
src/syncterm/bbslist.c
Log Message:
Terminate parity_enum

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Wed Nov 20 14:35:10 2024

https://gitlab.synchro.net/main/sbbs/-/commit/d256c540f06ca1c3f335ac19
Modified Files:
src/syncterm/bbslist.c
Log Message:
Remove unused variable.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Fri Nov 22 15:11:13 2024

https://gitlab.synchro.net/main/sbbs/-/commit/2ff66c278ca6b77f7436b25b
Modified Files:
src/syncterm/bbslist.c
Log Message:
Fix editing of name broken in earlier commit, refactor

Split generating help into separate function
- Regenerated when the connection type changes
Split generation the opt list into separate function
- Regenerated after handling any selection

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Fri Nov 22 15:28:34 2024

https://gitlab.synchro.net/main/sbbs/-/commit/c1284baafe7ff60e8ef6828e
Modified Files:
src/syncterm/bbslist.c
Log Message:
Use enum values for field names

Easier to match up than numbers.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

From Deucе@VERT to Git commit to main/sbbs/master on Fri Nov 22 15:50:55 2024

https://gitlab.synchro.net/main/sbbs/-/commit/4143d73fd3d49364d492dcad
Modified Files:
src/syncterm/bbslist.c
Log Message:
Remove accidental zero-width unicode character.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

src/syncterm/bbslist.c