• src/sbbs3/file.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Apr 25 19:36:21 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/791c5c0516af059a65652f88
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Consolidate the uploader security info (host/ip/prot) on one line

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Apr 26 22:34:45 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/73517eeebd142f73ee76b7eb
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Fix error when moving files

    e.g. file.cpp line 239 (removefile) removing "filename.zip" access=-203 info=smb_freemsgdat reading allocation record at offset 1108

    Also, if there is an error removing the original file from the filebase, don't proceed to move the actual file (and log a successful move).

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat May 15 13:22:14 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/cb12ed0d532bdd8fbe1d7200
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Fix use of uninitialized variable in editfilename()

    CID 331582

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat May 15 23:09:56 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/90bf6cd5ad2e66840e39ca88
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Fix potential NULL deref in editfiledesc()

    If the file doesn't already have a description, f->desc may be NULL.
    Remove the redundant user name in the "removed file" log message.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu May 20 20:07:54 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/4c912de90fe7e8599eb9a90e
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Have movefile() leave the original file with the delete attribute

    This has the effect of the file being listed as absent/deleted in the listing that's in memory. As requested by Phil, plt via irc.

    Moving a file after this change did result in a crash once, but I couldn't reproduce it with a debugger attached.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat May 22 15:52:38 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/c5d69236fbf29198f1b86f9a
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Don't abort the file-info edit prompts if no uploader name is entered

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jun 6 20:07:10 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/4415d99b6b609f55cc867efa
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    More use of K_TRIM when prompting for filename/spec

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Jun 11 18:24:11 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/48598fc02f504791f8dce1d2
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Fix memory leak (of extended description) when moving files

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Mar 13 23:33:54 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/db2dea665d0ce8883567834c
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Use new i64toac() function to support files > 4GB in size

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Mar 21 00:01:20 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/26028bcaf0d7c69d8423a98c
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Fix newly-encountered GCC warning

    comparison of integer expressions of different signedness: ‘off_t’ {aka ‘long int’} and ‘uint64_t’ {aka ‘long unsigned int’}

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Mar 21 01:35:26 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/8f3f0c54ae19b2f12c8ea2e9
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Merge branch 'master' of gitlab.synchro.net:main/sbbs

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Mar 21 01:38:57 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/066055393089c96afc248f04
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Fix newly introduced GCC warning

    warning: invalid suffix on literal; C++11 requires a space between literal and string macro

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun May 8 00:43:58 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/066c4bd3c14c5d6bdf8f00f9
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Print the upload TCP protocol (when available) w/user name, not host/IP

    Long hostnames would prevent the protocol from being shown. Also, non-operators should be able to see the protocol used to upload files.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sat Feb 11 13:35:16 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/0b2dc3d91bee9c4670ce5e0a
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    Set destination directory in proper file_t instance in movefile()

    This fixes the issue (#515) that was introduced 9 months ago
    (after the v3.19b release) with commit b1449b273cec4d.

    Also:
    movefile() will now log an error message if addfile() fails.
    Fix the message logged when the file is successfully moved.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net