1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/smbutil.c

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon May 10 17:05:21 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f92a14cd738c03df9505702e
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Fix issue with the import message commands introduced in previous commit

    The fread() usage here did not need "addressing" (Commit 1b56dc96).

    This caused messages posted via smbutil to be short (e.g. 0 or 1 bytes
    in length). Reported by Accession via Idle Relay Chat.

    Also, don't call strlen() on msgtxt which could be NULL, causing segfault
    in final printf() callin in postmsg().

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Jun 5 14:53:40 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/d653a6d97c48dc47819e399f
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Add new commands to flag/unflag all messages for deletion

    The command to delete and remove all messages is changed from 'd' to 'D'.
    This operation is not reversable.

    New commands are 'd' (flag all msgs for deletion) and 'u' (undelete all msgs).

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jun 6 04:02:21 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/19975dfafd9041acaf6e3221
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Resolved sign/unsigned compare warning

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Feb 23 23:25:45 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/7be94765a4b73ecb93c97319
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Comment intentional case fall-through

    CID 33205

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Mar 1 22:43:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/2cd7d767f3e71cd522c73da1
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Zero-init 'ms'g' before use

    Addresses CID 350316

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Mar 1 22:43:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/831438fad7fb9cfcf4ec72c9
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Zero-init 'msg' before use

    Addresses CID 350312

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Mar 1 22:43:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/31864868ed05e82aa601f466
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Zero-init 'msg' before use

    CID 350279

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Mar 2 18:14:50 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/ecce2a8a402e7330486bf423
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Detect smb_fallocdat() and ftell() failures

    CID 33245

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Mar 2 18:14:50 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/9169e4aa90c65ce7d5bd8f2d
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Detect/report smb_fallochdr() and ftell() failures

    Fix CID 33244: Argument cannot be negative

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Mar 3 16:45:56 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/c40ef9243970d5228e7473ef
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Check for negative filelength() return values

    e.g. CID 229593: Negative loop bound

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Mar 12 21:09:16 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/07580ea7b1b6e204c4c5400b
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Display textual version of msg attributes when using 'r'ead command

    Also displays net and aux attribute values when non-zero (weren't displayed
    at all with the 'r'ead command previously).

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Mar 12 23:21:15 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/4b5a75c3ae3f207e6cc71cbd
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Address warnings introduced in previous commit

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Mar 13 00:26:38 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/5ee74077200205a13bbbf60c
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Fix CID 350312: Uninitialized scalar variable

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Sep 9 18:29:23 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/d84b8e3d6c917620ab0c8a3c
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    Indicate vote/poll messages and files (with details) when listing msgs/files

    Add '-v' (increase verbosity) option, used to display msg dates and timezones ... when using the the 'l' (list messages) command (to view post date/time). Use '-vv' or '-v -v' to see timezones of messages.

    The -v option is now also applicable to the 'v' (view) messages command (now redundant with the 'V' command).

    Features as requested by Nelgin as part of issue #786.

    Removed day-of-week from date/times displayed. We don't need that level of user-friendliness with this tool.
    However, we are also displaying 12h/am/pm times. Some sysops probably would prefer 24hour time, so that should be considered at some point.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Sep 17 12:06:15 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/daa1b7882234d005c0b2a3ea
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    NUL-terminate the SMB fileidxrec_t.name field, just in case

    The terminating NUL is actually part of the index record, but with file corruption, it's technically possible the NUL could be missing.

    Fixes CID 509554

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net