https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3654

Why 'NXDOMAIN' as a magic string to return and check for? `resove_ip()` returns `null` on failure to resolve, so just check for a non-truth result of `checkip()` and return the return value of `resolve_ip()` here.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3655

So here (and later) `checkip()` is returning `false`, but the code that checks the return value of `checkip()` only checks for 'NXDOMAIN' and `undefined` as handles those as expected return values.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3656

hard-coding the DNSBL server? Icky.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3657

Because I suck and I did what works for me just so we can get it working and stop the bots.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3658

I thought I changed these to just return; rather than return false;. I'll have to check.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3659

It was either that or wait a week while I figure out how to add it to the ircd config. Sorry I bothered, I'm sure.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3661

You'd want to return a value in all cases, not just `return;`

But make sure you're actually checking-for/handling the possible return values in the caller.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3662

or just use `function checkip(ip, rbl)` and then pass the hard-coded (for now) DNSBL server at the call site. Then in the future, when someone adds the configurability, this function would still need no change.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

Re: Added RBL lookups on connection via DroneDL.
By: Nigel Reed to GitLab note in main/sbbs on Fri Jul 07 2023 08:12 pm

https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3657

Because I suck and I did what works for me just so we can get it working and stop the bots.

are you getting those supernets attacks.
---
■ Synchronet ■ ::: BBSES.info - free BBS services :::

Re: Added RBL lookups on connection via DroneDL.
By: MRO to Nigel Reed on Fri Jul 07 2023 10:58 pm

Re: Added RBL lookups on connection via DroneDL.
By: Nigel Reed to GitLab note in main/sbbs on Fri Jul 07 2023 08:12 pm

https://gitlab.synchro.net/main/sbbs/-/merge_requests/297#note_3657

Because I suck and I did what works for me just so we can get it working and stop the bots.

are you getting those supernets attacks.

Yup.
--
digital man (rob)

Breaking Bad quote #1:
Just because you shot Jesse James, don't make you Jesse James. - M. Ehrmantraut Norco, CA WX: 66.3°F, 73.0% humidity, 1 mph SE wind, 0.00 inches rain/24hrs
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

Re: Added RBL lookups on connection via DroneDL.
By: Digital Man to MRO on Fri Jul 07 2023 09:21 pm

Because I suck and I did what works for me just so we can get it working and stop the bots.

are you getting those supernets attacks.

Yup.

Those dipshits do that stuff around every holiday.

Really, the best thing to stop like 99% of that stuff is to run your ircd on a non standard port. i dropped 6667 and only use ssl now and i don't get any attacks.

I was surprised they didn't even find me on april floods day.
Last year i stopped a lot of their attacks just by banning strings in their script, but i see now they are masking it.
https://i.imgur.com/UZyiQJL.png

Right now, They are attacking my channels on efnet. most activity it's seen all year.

---
■ Synchronet ■ ::: BBSES.info - free BBS services :::